Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong reset behavior for sort by, group by, and sort group by dialog #281

Closed
thinkh opened this issue Apr 3, 2020 · 1 comment · Fixed by #287
Closed

Wrong reset behavior for sort by, group by, and sort group by dialog #281

thinkh opened this issue Apr 3, 2020 · 1 comment · Fixed by #287
Assignees
@sgratzl
Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working

Comments

@thinkh
Copy link
Member

thinkh commented Apr 3, 2020

  • Release number or git hash: 9d9c5de
  • Web browser version and OS: Chrome 80

Steps to reproduce

  1. Open builder3.html
  2. Open More ... -> Sort By ...
  3. Reset dialog
  4. Confirm

Try different dialogs.

Observed behavior

lineup-reset-dialogs

In Sort By, Group By, and Sort Group By, clicking on Reset to default values doesn't disable the sorting / grouping. It seems that it only works sometimes.

Expected behavior

The sorting and grouping should be removed from the respective hierarchies.
@thinkh thinkh added type: bug Something isn't working lineup: v4 All issues related to LineUp v4 labels Apr 3, 2020
@thinkh thinkh changed the title Wrong behavior when resetting sort by, group by, and sort group by dialog Wrong reset behavior for sort by, group by, and sort group by dialog Apr 3, 2020
sgratzl added a commit that referenced this issue Apr 6, 2020
@sgratzl
fix #281 reset group/sort
8eb7574
@sgratzl sgratzl linked a pull request Apr 6, 2020 that will close this issue
Fix reset of group and sort dialog #287
Merged
4 tasks
@thinkh
Copy link
Member Author

thinkh commented Apr 6, 2020

@sgratzl Please book your work for this issue on task M2 LineUp UI improvements.

@sgratzl sgratzl mentioned this issue Apr 6, 2020
Merged
4 tasks
@sgratzl sgratzl closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratzl sgratzl

Labels
lineup: v4 All issues related to LineUp v4 type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reset of group and sort dialog lineupjs/lineupjs
2 participants
@sgratzl @thinkh