Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lineup column name is prone to js injections #455

Closed
dg-datavisyn opened this issue Jul 21, 2021 · 0 comments · Fixed by #480
Closed

Lineup column name is prone to js injections #455

dg-datavisyn opened this issue Jul 21, 2021 · 0 comments · Fixed by #480
Assignees
@sgratzl
Labels
type: bug Something isn't working

Comments

@dg-datavisyn
Copy link

dg-datavisyn commented Jul 21, 2021 •
edited
Loading

When I name a column document.body.innerHTML = '<img src="empty.gif" onerror="alert();this.parentNode.removeChild(this);" />'; the code gets executed

To Reproduce

  1. Name a column document.body.innerHTML = '<img src="empty.gif" onerror="alert();this.parentNode.removeChild(this);" />';

The column has the name, but nothing happens

image
@sgratzl sgratzl mentioned this issue Aug 27, 2021
Merged
3 tasks
@sgratzl sgratzl self-assigned this Aug 27, 2021
@sgratzl sgratzl added the type: bug Something isn't working label Aug 27, 2021
@sgratzl sgratzl linked a pull request Aug 27, 2021 that will close this issue
sanitize column labels, ... #480
Merged
3 tasks
@sgratzl sgratzl closed this as completed Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratzl sgratzl

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sanitize column labels, ... lineupjs/lineupjs
2 participants
@sgratzl @dg-datavisyn