Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize column labels, ... #480

Merged
merged 3 commits into from
Sep 14, 2021
Merged

sanitize column labels, ... #480

merged 3 commits into from
Sep 14, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 27, 2021

closes #455

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

changes a bunch of renderings to avoid rendering user input as HTML

@sgratzl sgratzl added the type: feature New feature or request label Aug 27, 2021
@sgratzl sgratzl self-assigned this Aug 27, 2021
@netlify
Copy link

netlify bot commented Aug 27, 2021 •
edited

✔️ Deploy Preview for lineupjs ready!

🔨 Explore the source changes: 73db26a

🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/6140a381572c740007c0eace

😎 Browse the preview: https://deploy-preview-480--lineupjs.netlify.app

@sgratzl sgratzl requested a review from thinkh August 27, 2021 02:33
@sgratzl sgratzl linked an issue Aug 27, 2021 that may be closed by this pull request
Lineup column name is prone to js injections #455
Closed
thinkh
thinkh approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and the additional demo file. It looks good to me. Just a few minor changes, if you'd like to add them.

src/ui/domElementCache.ts Outdated Show resolved Hide resolved
src/ui/dialogs/StringFilterDialog.ts Outdated Show resolved Hide resolved
@sgratzl @thinkh
feat: Apply suggestions from code review
73db26a 
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
@sgratzl sgratzl merged commit ae31245 into develop Sep 14, 2021
@sgratzl sgratzl deleted the sgratzl/sanitize branch September 14, 2021 13:40
thinkh added a commit to datavisyn/tdp_core that referenced this pull request Jan 7, 2022
@thinkh
Changes due to LineUp text sanitation in v4.4.0
cc97dc5 
With PR lineupjs/lineupjs#480 text sanitation was introduced.
The searchbox' `formatItem()` has changed.
This commit changes our format function accordingly.
It also converts the `&hellip;` to the unicode pendant.
@thinkh thinkh mentioned this pull request Jan 7, 2022
Merged
@puehringer puehringer mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@sgratzl sgratzl

Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lineup column name is prone to js injections
2 participants
@sgratzl @thinkh