Prevent over-sizing of group heatmaps in nested columns #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `width:100%` only the gap between the nested columns would disappear. Hence, we must subtract the gap from the width to stay inline with the (nested column) grid. Caleydo/lineup_app#46
thinkh
changed the title
|
doesn't work for me, in Chrome I get:
i.e Sass is not translating this variable thus the whole rule is invalid and does nothing. |
|
Thanks for pointing out. It's fixed now. I needed to escape the Sass variable. |
|
one thing that I didn't get. when you tested this PR with the buggy CSS selector and still the behavior wasn't there anymore. How can this fix, fix the bug or is there a bug at all? |
|
Well, I just didn't test it the way I should have tested it. 😄 But intesterstingly the sass-lint also didn't warn me... 🤔 |
|
can you please update the test file such that I can reproduce the initial bug |
|
I added the
With the width it is correct:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes Caleydo/lineup_app#46
prerequisites:
Summary
The over-sizing is caused by the increased row height for aggregated groups.
Reducing the row height to the standard
18pxwill result in a normal heatmap width for nested columns.As soon as I increase the height the width of the nested heatmaps increases exceeds the column.
By adding a
width:100%the heatmaps stay within their column width.However, now the gap between the nested columns disappeared. Hence, we must subtract the gap from the width to stay inline with the (nested column) grid.