Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sgratzl/groupsort #144

Merged
merged 7 commits into from
Mar 14, 2019
Merged

Sgratzl/groupsort #144

merged 7 commits into from
Mar 14, 2019

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Mar 13, 2019 •
edited
Loading

closes #141

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

fixes the group sorting issues

without sorting and two levels:

2019-03-13 16_17_44-LineUp Builder Test

group sorted by A:

2019-03-13 16_16_47-Window

@sgratzl sgratzl self-assigned this Mar 13, 2019
@sgratzl sgratzl added this to Needs review in lineup Mar 13, 2019
@sgratzl sgratzl merged commit 1414382 into develop Mar 14, 2019
lineup automation moved this from Needs review to Done Mar 14, 2019
@sgratzl sgratzl deleted the sgratzl/groupsort branch March 14, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgratzl sgratzl

Labels
None yet
Projects
No open projects
lineup
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sgratzl