-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make renderer and utils function publicly available (i.e., remove @internal markers) #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the changes.
@thinkh @lehnerchristian @sgratzl would you mind also removing the |
would be fine for me. @thinkh , what would you say? |
@dvmichaelpuehringer I'm fine with this change. Could you please open another issue/PR for this? @lehnerchristian Could you please file an additional PR for the LineUp 4 then? |
re internal: ok
don't get it tbh, you mean when the user click on the filter icon it will automatically check this one checkbox? |
@sgratzl Yes, as there is currently no way of passing a default configuration unfortunately, this would be one way of checking it by default. I.e. when a filter is applied, filter the missing values if it was not unchecked. |
sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me.
closes #203
prerequisites:
Summary
@internal
marker from Renderer, which makes them publicly available in the .d.ts files