Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined sublabel in updateHeader() #264

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Fix undefined sublabel in updateHeader() #264

merged 2 commits into from
Mar 18, 2020

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Mar 18, 2020

Closes #263

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

Fixes the undefined element if no sublabel is set.

@thinkh thinkh added type: bug Something isn't working release: patch PR merge results in a new patch version labels Mar 18, 2020
@thinkh thinkh requested a review from sgratzl March 18, 2020 10:29
@thinkh thinkh linked an issue Mar 18, 2020 that may be closed by this pull request
Sublabel is undefined when grouping or sorting a column #263
Closed
@sgratzl sgratzl merged commit b4b0222 into lineup-v4 Mar 18, 2020
@sgratzl sgratzl deleted the thinkh/263_fix-undefined-sublabel branch March 18, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgratzl sgratzl Awaiting requested review from sgratzl

Assignees

@sgratzl sgratzl

Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sublabel is undefined when grouping or sorting a column
2 participants
@thinkh @sgratzl