Harmonize dialogs by adding apply, cancel, and reset buttons

[sgratzl]

closes #229, #272, #277

prerequisites:

• branch is up-to-date with the branch to be merged with, i.e. develop
• build is successful
• code is cleaned up and formatted
• tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

unifies the dialogs as described in the issue

[thinkh]

Thanks for the first implementation. I ran a first quick test and it looks already very promising. I found a couple of things that needs to be addressed.

1. It looks like the live preview for filter and visualization dialogs are disabled. For the filter dialog the live preview works for the filters in the side panel, but it does not for the column filter. Can we enable the live preview for the filter dialogs (including the categorical filter dialog) and visualization by default? I think as a rule of thumb, all dialogs that had no cancel/reset/apply button before should have a live preview now, but in order to confirm the change the user must click on the apply button.

2. When I open a sub-dialog from the more menu, change something and apply the changes, the list of more values remains open. In previous LineUp versions the dialog and the more menu were closed on apply.

[sgratzl]

re 1: done

re 2: when I try https://lineup.js.org/app_develop/#soccer it behaves the same. just clicking outside will close all dialogs. A proper dialog ending (cancel, apply) won't close the more dialog

[thinkh]

1. Thanks, that looks already better. I have just a minor typo in the last commit.

2. You are right. Then let's keep it like this for now. I will discuss this behavior with the others, if we want to change it.

[sgratzl]

. Alternatively, would it be possible to add further events when user (a) opens a dialog and (b) applies the changes? With that event combination we should be able to filter out the live preview events.

which instance should trigger those events? it cannot be part of any model (column, ranking, data provider) since it is purely UI related

[thinkh]

which instance should trigger those events? it cannot be part of any model (column, ranking, data provider) since it is purely UI related

What about the LineUp instance itself? Alternatively you could add a dedicated event dispatcher for UI-releated events.

[thinkh]

Thanks for fixing #277 and implementing the events. With this addition we should be able to filter out the live preview events. In general it works now very smooth. While testing I just found two bugs:

1. Reset does not work for missing value rows in categorical column filter

1. Filter missing values of categorical column
2. Confirm dialog
3. Open filter dialog again and click reset

Nothing happens. As I user, I would expect that the checkbox is unchecked on reset.

2. Cannot filter missing values in numbers column

1. Open the missing.html demo
2. Open the filter dialog for the numbers column

There are no missing value rows found, even though there are clearly some in the dataset. As I user, I would expect that the checkbox works and I can filter out missing values rows.

[sgratzl]

done

[thinkh]

I think that looks good now. Thanks for implementing and unifying all of the dialogs which is a huge usability improvement! I'm going to merge the PR. If we find further bugs, we will open separate issues for it.