Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve last column resizing #278

Merged
merged 5 commits into from
Apr 6, 2020
Merged

improve last column resizing #278

merged 5 commits into from
Apr 6, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Mar 31, 2020

closes #228

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

wip of a better resize experience

@thinkh
Copy link
Member

thinkh commented Apr 3, 2020

Thanks for your draft. It looks already very promising and works well.

While testing I noticed that the scrollbar is jumping around after I stopped moving my mouse (while dragging) or released the mouse button. Why is that happening (i.e., what the is the reason for this behavior)? Can you point me to the implementation where this happens, maybe I can play a bit around and try to optimize it?

lineup-resize-scrollbar

P.S. I saw in the code that there is a setTimeout with 1200 ms.

@sgratzl sgratzl linked an issue Apr 3, 2020 that may be closed by this pull request
@sgratzl sgratzl marked this pull request as ready for review April 6, 2020 09:28
@sgratzl
Copy link
Member Author

sgratzl commented Apr 6, 2020

I tried to improve the behavior as good as its get. The columns size would still jump, cause it is too expensive to rerender all the time but I use a helper element that is used for a smoother experience.

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. Now it works much smoother.

lineup-resizing

I would keep/merge it like this and come back if necessary.

@thinkh thinkh merged commit a926cad into lineup-v4 Apr 6, 2020
@thinkh thinkh deleted the sgratzl/resizecolumn branch April 6, 2020 12:00
@thinkh thinkh added lineup: v4 All issues related to LineUp v4 type: feature New feature or request labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lineup: v4 All issues related to LineUp v4 type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve resizing of last / right most column
2 participants