Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reset of the filter histogram #288

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Fix reset of the filter histogram #288

merged 2 commits into from
Apr 7, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Apr 6, 2020

closes #282

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

re renders the number filter histogram in case of the order changed = filter was successfully applied or reset

@sgratzl sgratzl requested a review from thinkh April 6, 2020 11:25
@sgratzl sgratzl linked an issue Apr 6, 2020 that may be closed by this pull request
Histogram does not update on reset in numerical column filter dialog #282
Closed
@thinkh thinkh changed the title fix #282 reset filter histogram Fix reset the filter histogram Apr 6, 2020
@thinkh thinkh changed the title Fix reset the filter histogram Fix reset of the filter histogram Apr 7, 2020
thinkh
thinkh approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests. 👍

@thinkh thinkh added the lineup: v4 All issues related to LineUp v4 label Apr 7, 2020
@thinkh thinkh merged commit 36d2bfa into lineup-v4 Apr 7, 2020
@thinkh thinkh deleted the sgratzl/reset_hist branch April 7, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
lineup: v4 All issues related to LineUp v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Histogram does not update on reset in numerical column filter dialog
2 participants
@sgratzl @thinkh