Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI error by updating the cache key #298

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Apr 10, 2020

Closes #297

Prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

Following https://stackoverflow.com/a/58886629

@thinkh thinkh requested a review from sgratzl April 10, 2020 07:41
@thinkh thinkh changed the title Update cache key Fix CircleCI error by updating the cache key Apr 10, 2020
@thinkh thinkh added the lineup: v4 All issues related to LineUp v4 label Apr 10, 2020
@thinkh thinkh mentioned this pull request Apr 10, 2020
4 tasks
@thinkh
Copy link
Member Author

thinkh commented Apr 10, 2020

It looks like this fix only fixes the build of a single branch (see CircleCI build of #301). When pushing a new branch we would need to update the cache key again...

Edit

I forgot to use the updated CircleCI config in #301. After merging this branch it works also there as expected.

@sgratzl sgratzl merged commit 14dffcf into lineup-v4 Apr 10, 2020
@sgratzl sgratzl deleted the thinkh/297_fix-circleci branch April 10, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lineup: v4 All issues related to LineUp v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants