Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dragging of slider #304

Merged
merged 5 commits into from
Apr 16, 2020
Merged

Improve dragging of slider #304

merged 5 commits into from
Apr 16, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Apr 14, 2020

closes #302

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

2020-04-14 11_26_47-Window

dragging

@sgratzl sgratzl requested a review from thinkh April 14, 2020 09:29
@sgratzl sgratzl linked an issue Apr 14, 2020 that may be closed by this pull request
Improve interaction with range sliders #302
Closed
thinkh
thinkh approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like charme and is a huge improvement in the user interaction. 👍

Just a minor question/hint. If the missing ! is intentionally we can merge it like it is.

src/internal/drag.ts Outdated Show resolved Hide resolved
@thinkh thinkh changed the title improve dragging Improve dragging of slider Apr 14, 2020
@thinkh thinkh merged commit 9f0d7a0 into lineup-v4 Apr 16, 2020
@thinkh thinkh deleted the sgratzl/drag branch April 16, 2020 08:42
@thinkh thinkh added the lineup: v4 All issues related to LineUp v4 label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
lineup: v4 All issues related to LineUp v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve interaction with range sliders
2 participants
@sgratzl @thinkh