Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to copy command and copy selected rows #510

Merged
merged 9 commits into from
Dec 3, 2021
Merged

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 22, 2021

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

add support for copying a TSV table into the clipboard upon copy command. If rows are selected it will only be the selected rows otherwise the whole table

@sgratzl sgratzl added the type: feature New feature or request label Nov 22, 2021
@sgratzl sgratzl requested a review from thinkh November 22, 2021 14:20
@sgratzl sgratzl self-assigned this Nov 22, 2021
@netlify
Copy link

netlify bot commented Nov 22, 2021

✔️ Deploy Preview for lineupjs ready!

🔨 Explore the source changes: b06e66e

🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/61aa0abe0298910008dd0496

😎 Browse the preview: https://deploy-preview-510--lineupjs.netlify.app

@thinkh
Copy link
Member

thinkh commented Nov 22, 2021

How can I test this?

  1. Open a Netlify PR demo
  2. Select some rows
  3. Ctrl + C
  4. Open an editor
  5. Ctrl + V

The result are not the selected rows.

@sgratzl
Copy link
Member Author

sgratzl commented Nov 22, 2021

when I do it:
copy paste2

ctrl-c and ctrl-v also work as expected

@thinkh
Copy link
Member

thinkh commented Nov 23, 2021

Aha! I can confirm that it works with Chrome, but it does not work with Firefox 94 (which I used for testing). Could you please have a look if there is a way to make it compatible with Firefox?

@sgratzl
Copy link
Member Author

sgratzl commented Nov 24, 2021

Aha! I can confirm that it works with Chrome, but it does not work with Firefox 94 (which I used for testing). Could you please have a look if there is a way to make it compatible with Firefox?

should be fixed. Firefox doesn't allow async manipulation of the clipboard

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now it works also in Firefox.

@sgratzl sgratzl merged commit 9402e7f into develop Dec 3, 2021
@sgratzl sgratzl deleted the sgratzl/exportrow branch December 3, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants