Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapping dialog warning #531

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Add mapping dialog warning #531

merged 2 commits into from
Jan 7, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Dec 23, 2021

closes #483

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

add a static warning:

image

@sgratzl sgratzl added the type: feature New feature or request label Dec 23, 2021
@sgratzl sgratzl requested a review from thinkh December 23, 2021 16:39
@sgratzl sgratzl self-assigned this Dec 23, 2021
@netlify
Copy link

netlify bot commented Dec 23, 2021 •
edited
Loading

✔️ Deploy Preview for lineupjs ready!

🔨 Explore the source changes: 8f03eb9

🔍 Inspect the deploy log: https://app.netlify.com/sites/lineupjs/deploys/61cdc2e4cf4f1200076ac0ae

😎 Browse the preview: https://deploy-preview-531--lineupjs.netlify.app

@thinkh
Copy link
Member

thinkh commented Dec 29, 2021

Thanks for implementing this warning. Is it possible to show this warning only if the input domain has been changed? This would cause less confusion to users.

@sgratzl
Copy link
Member Author

sgratzl commented Dec 30, 2021

Thanks for implementing this warning. Is it possible to show this warning only if the input domain has been changed? This would cause less confusion to users.

done

thinkh
thinkh approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Looks good to me. 👍

@sgratzl sgratzl merged commit a3cdfe1 into develop Jan 7, 2022
@sgratzl sgratzl deleted the sgratzl/warning_mapping branch January 7, 2022 13:33
@thinkh thinkh mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@sgratzl sgratzl

Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgratzl @thinkh