-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade dependencies #566
upgrade dependencies #566
Conversation
✅ Deploy Preview for lineupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this branch locally and couldn't finish yarn run build
or yarn run build:dev
. Here are my steps:
- Switch to this branch
- Run
yarn install
- Run
yarn -v
->3.2.0
- Run
node -v
->v14.19.0
- Run
yarn run build
-> never terminates until I cancel it and does not log anything
Do you have an idea what could be the problem here? I see with netlify build that it should build in general.
Beside this there is only a minor comment below.
re build: not sure what is going on. I had to update to the latest version (16.15) and then it worked. I guess that is also the reason why the CI works. |
I can confirm that the build works with Node 16.
I've added a comment to the development setup in the README.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the compatibility changes. It looks good to me now.
closes
prerequisites:
Summary