Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dependencies #566

Merged
merged 7 commits into from
May 11, 2022
Merged

upgrade dependencies #566

merged 7 commits into from
May 11, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented May 7, 2022

closes

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

font-awesome uses a custom function
@sgratzl sgratzl added the chore label May 7, 2022
@sgratzl sgratzl requested a review from thinkh May 7, 2022 19:09
@sgratzl sgratzl self-assigned this May 7, 2022
@netlify
Copy link

netlify bot commented May 7, 2022

Deploy Preview for lineupjs ready!

Name Link
🔨 Latest commit 4073d1b
🔍 Latest deploy log https://app.netlify.com/sites/lineupjs/deploys/627b66d166dc3100096e09f5
😎 Deploy Preview https://deploy-preview-566--lineupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this branch locally and couldn't finish yarn run build or yarn run build:dev. Here are my steps:

  1. Switch to this branch
  2. Run yarn install
  3. Run yarn -v -> 3.2.0
  4. Run node -v -> v14.19.0
  5. Run yarn run build -> never terminates until I cancel it and does not log anything

Do you have an idea what could be the problem here? I see with netlify build that it should build in general.

Beside this there is only a minor comment below.

src/styles/_common.scss Outdated Show resolved Hide resolved
@sgratzl
Copy link
Member Author

sgratzl commented May 9, 2022

re build: not sure what is going on. I had to update to the latest version (16.15) and then it worked. I guess that is also the reason why the CI works.

@thinkh
Copy link
Member

thinkh commented May 11, 2022

I can confirm that the build works with Node 16.

nvm use 16
Now using node v16.14.2 (npm v8.5.0)

I've added a comment to the development setup in the README.md.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the compatibility changes. It looks good to me now.

@sgratzl sgratzl merged commit 674ebd3 into develop May 11, 2022
@sgratzl sgratzl deleted the sgratzl/upgrade branch May 11, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants