Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clear button to selection column #590

Merged
merged 1 commit into from
Aug 2, 2022
Merged

feat: add clear button to selection column #590

merged 1 commit into from
Aug 2, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 2, 2022

closes #501

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

menu entry:

image

side panel:

image

@sgratzl sgratzl added the type: feature New feature or request label Aug 2, 2022
@sgratzl sgratzl requested a review from thinkh August 2, 2022 01:56
@sgratzl sgratzl self-assigned this Aug 2, 2022
@netlify
Copy link

netlify bot commented Aug 2, 2022 •
edited

✅ Deploy Preview for lineupjs ready!

Name Link
🔨 Latest commit 6df7099
🔍 Latest deploy log https://app.netlify.com/sites/lineupjs/deploys/62e8844ecf4a550009e5c077
😎 Deploy Preview https://deploy-preview-590--lineupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thinkh
thinkh approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works as intended.

@sgratzl sgratzl merged commit e7983e5 into develop Aug 2, 2022
@sgratzl sgratzl deleted the sgratzl/clearselection branch August 2, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@sgratzl sgratzl

Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgratzl @thinkh