Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow for custom HTML label generation #613

Merged
merged 1 commit into from
Apr 17, 2023
Merged

feat: allow for custom HTML label generation #613

merged 1 commit into from
Apr 17, 2023

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Dec 7, 2022 •
edited
Loading

closes #608

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

alternative variant from what we have discussed:

the labelAsHTML allows either a boolean or a function that is rendering HTML for a given col (desc) in a given context.

@sgratzl sgratzl added the type: feature New feature or request label Dec 7, 2022
@sgratzl sgratzl self-assigned this Dec 7, 2022
@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited
Loading

✅ Deploy Preview for lineupjs ready!

Name Link
🔨 Latest commit d103dd1
🔍 Latest deploy log https://app.netlify.com/sites/lineupjs/deploys/639002c0607855000810504e
😎 Deploy Preview https://deploy-preview-613--lineupjs.netlify.app/htmllabel
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thinkh thinkh linked an issue Feb 13, 2023 that may be closed by this pull request
Dedicated field for HTML labels #608
Closed
thinkh
thinkh approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature. Looks good to me. 👍

@thinkh thinkh merged commit 6dbfd00 into develop Apr 17, 2023
@thinkh thinkh deleted the sgratzl/renderer branch April 17, 2023 09:54
@thinkh thinkh mentioned this pull request Jul 31, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@sgratzl sgratzl

Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dedicated field for HTML labels
2 participants
@sgratzl @thinkh