Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive link #635

Merged
merged 2 commits into from
Aug 18, 2023
Merged

derive link #635

merged 2 commits into from
Aug 18, 2023

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 15, 2023

closes #634

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

derive a link type if the value starts with http, https, or ftp

@sgratzl sgratzl added type: feature New feature or request release: minor PR merge results in a new minor version labels Aug 15, 2023
@sgratzl sgratzl self-assigned this Aug 15, 2023
@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for lineupjs ready!

Name Link
🔨 Latest commit 92d6988
🔍 Latest deploy log https://app.netlify.com/sites/lineupjs/deploys/64dad9713030ee0009483a7b
😎 Deploy Preview https://deploy-preview-635--lineupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@puehringer
Copy link
Contributor

Looks good to me, thanks for the quick implementation!

@sgratzl sgratzl merged commit e779ca8 into develop Aug 18, 2023
6 checks passed
@sgratzl sgratzl deleted the sgratzl/derive-link branch August 18, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants