Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making FileDownloadTask public #6

Closed
minimalviking opened this issue Jan 5, 2016 · 3 comments
Closed

Consider making FileDownloadTask public #6

minimalviking opened this issue Jan 5, 2016 · 3 comments
Assignees

Comments

@minimalviking
Copy link

I think making FileDownloadTask public would be very beneficial, it would allow extending this class for custom usage of the library

@Jacksgong
Copy link
Collaborator

Thanks for your deep thinking.

Could you give me some cases and I will consider about it.

ps: I hide the FileDownloadTask Class because there are some internal mechanisms. (like: Let outside create tasks just only through FileDownloader. strict and safe) (and already public BaseDownloadTask, you can do almost everything you want on it.)

@Jacksgong Jacksgong self-assigned this Jan 5, 2016
@minimalviking
Copy link
Author

Oh you're right - I've just noticed that BaseDownloadTask has a setTag method:)

@Jacksgong
Copy link
Collaborator

Yes, you got it. thanks anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants