Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igraph py2 compatibility #302

Merged
merged 1 commit into from Jul 1, 2017
Merged

igraph py2 compatibility #302

merged 1 commit into from Jul 1, 2017

Conversation

xrotwang
Copy link
Contributor

@xrotwang xrotwang commented Jul 1, 2017

igraph seems to use "real" python attributes to store additional data for
edges and vertices. Thus, it requires the attribute names to be ASCII encoded
rather than unicode strings in python 2.

igraph seems to use "real" python attributes to store additional data for
edges and vertices. Thus, it requires the attribute names to be ASCII encoded
rather than unicode strings in python 2.
@codecov-io
Copy link

codecov-io commented Jul 1, 2017

Codecov Report

Merging #302 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   90.46%   90.46%   -0.01%     
==========================================
  Files         119      119              
  Lines       15817    15819       +2     
==========================================
+ Hits        14309    14310       +1     
- Misses       1508     1509       +1
Impacted Files Coverage Δ
lingpy/convert/graph.py 82.51% <25%> (-0.92%) ⬇️
lingpy/compare/phylogeny.py 82.62% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b79e9...704e18b. Read the comment docs.

@LinguList LinguList merged commit 0db88d1 into lingpy:master Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants