Fix idempotency in to_concepticon

[johenglisch]

I think I found the culprit.

[johenglisch]

Btw, I've been wondering about this sort key function:

pysem/src/pysem/glosses.py

Lines 343 to 347 in 903b6f1

	results = sorted(
	{row: True for row in results},
	key=lambda x: (x[-1], 1 if g.pos == x[-2] else 0, x[-3]),
	reverse=True,
	)[:max_matches]

It seems it compares the part of speech of a match to a variable called g. But from what I can tell g is just a temp variable used in the for loops right above. Is that intentional?

[LinguList]

How bad, yes!

[LinguList]

Can you provide a quick fix?

[LinguList]

Sorry, I should of course do so.

In [1]: from pysem.glosses import MAPPINGS
In [2]: MAPPINGS["de"]["arm"]
Out[2]: [['1674', 'POOR', 7, 'adjective', 1]]

[LinguList]

The rows, with the mappings, have the POS information in row[3]. So the correct order should be:

                key=lambda x: (x[-1], 1 if pos == x[-2] else 0, x[-3]),

pos is the part of speech that has been passed directly or not. If it is present and matches, it should be preferred, therefore we give 1.

[johenglisch]

Okay, thanks, I implemented the fix.

['1674', 'POOR', 7, 'adjective', 1]

Sry for going on another tangent but what do the elements in this list actually mean? From context I can reconstruct:

0: Concepticon ID
1: Concepticon Gloss
2: ?
3: Part of Speech
4: ?

(I suspect I knew the answer to this at some point and then forgot.)

[LinguList]

0: Concepticon ID
1: Concepticon Gloss
2: HOW OFTEN THIS WAS MAPPED TO THE GLOSS
3: Part of Speech
4: IF IT IS THE PRIMARY MAPPING (we use 1/0 in concepticon/mappings)

[LinguList]

The argument is: the more often you map something like "you (sg)" to Concepticon THOU, the more comfortable you are to map it another time.