Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kurdish Wiktionary (ku) #19

Merged
merged 29 commits into from Dec 1, 2021
Merged

Support Kurdish Wiktionary (ku) #19

merged 29 commits into from Dec 1, 2021

Conversation

pamputt
Copy link
Contributor

@pamputt pamputt commented Oct 17, 2021

Bot has been tested on ku.wiktionary.org (see https://ku.wiktionary.org/wiki/W%C3%AEk%C3%AEferheng:D%C3%AEwan/2021#Lingualibre_bot) and is expected to be work properly).

pamputt and others added 27 commits August 11, 2021 23:21
Beta version (still need to be tested widely)
Removed debug output
Beta version (still need to be tested widely)
Removed debug output
Beta version (still need to be tested widely)
Removed debug output
Remove extra line before Bilêvkirin section
@pamputt pamputt changed the title Support kuwiktionary Support Kurdish Wiktionary (ku) Oct 17, 2021
@hugolpz
Copy link
Member

hugolpz commented Nov 8, 2021

@pamputt , can you tell us a bit about these commits.
@Poslovitch , what is the process to follow to accept the current PRs ?

@pamputt
Copy link
Contributor Author

pamputt commented Nov 9, 2021

@pamputt , can you tell us a bit about these commits.

I do not know what to say more. After the merge LinguaLibreBot will add (properly) audio pronunciations on the Kurdish Wiktionary.

@hugolpz
Copy link
Member

hugolpz commented Nov 11, 2021

@pamputt hello : ),
First, Ideal github protocole requires a second coder to test a PR in real situation before the project accepts that PR. I'am not sure we have the human resources to do so tho.
Second, I think the bot got banned on wikidata or else recently, we need @Poslovitch's feedback on that.

@Poslovitch
Copy link
Member

Second, I thing the bot got banned on wikidata or else recently, we need @Poslovitch's feedback on that.

No it isn't, see : https://www.wikidata.org/w/index.php?diff=1526275540

@pamputt
Copy link
Contributor Author

pamputt commented Nov 30, 2021

The bot got the bot status (https://meta.wikimedia.org/wiki/Steward_requests/Bot_status#Lingua_Libre_Bot@kuwiktionary) so I think we can merge this branch and start to run the bot on kuwiktionary. I already performed tests before proposing this PR but I think it is better to star with a few recordings just to check that everything is still ok.

@Poslovitch
Copy link
Member

Alright. I'm merging this, but this will be put in production by the weekend.
Thanks for your work!

@Poslovitch Poslovitch merged commit 8cfdd04 into master Dec 1, 2021
@Poslovitch Poslovitch deleted the kuwiktionary branch December 1, 2021 07:58
@pamputt
Copy link
Contributor Author

pamputt commented Nov 29, 2022

Thanks for the merge but it seems that the bot has never run on kuwikt (https://ku.wiktionary.org/wiki/Taybet:Be%C5%9Fdar%C3%AE/Lingua_Libre_Bot). Something wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants