Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dictionnaire des Francophones #6

Merged
merged 1 commit into from Mar 23, 2023
Merged

Add Dictionnaire des Francophones #6

merged 1 commit into from Mar 23, 2023

Conversation

hugolpz
Copy link
Member

@hugolpz hugolpz commented Mar 22, 2023

@pamputt

The url and verb were copy-engineered from their SPARQL's Query Service.
Screenshot from 2023-03-22 14-34-28

@hugolpz hugolpz requested a review from pamputt March 22, 2023 13:31
@hugolpz hugolpz self-assigned this Mar 22, 2023
Copy link
Contributor

@pamputt pamputt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know how to test it. Especially where did you find the URL of DDF endpoint?
Otherwise, it looks good to me.

@pamputt
Copy link
Contributor

pamputt commented Mar 22, 2023

Actually, Noé can confirm the endpoint URL for sure. If you are not sure about this URL, I let you contact him (via the Wiktionnaire if needed).

@hugolpz
Copy link
Member Author

hugolpz commented Mar 23, 2023

Ok. The change is barely a copy-paste of existing code, with string variations, we move ahead and merge. 🎉
I added an example case in Help:SPARQL/test#Francophones.

✅ UPDATE HAVE BEEN DEPLOYED, THIS PR IS DONE.


BUG (#7): Query to dictionnaire des francophones fails.
See : Right click > Inspect > Network > filter with sparql.
I suspect a config on their side, investigation via #7.

@hugolpz hugolpz merged commit 8879ed5 into master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants