Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode chaining arrows #6

Closed
elfranne opened this issue Oct 19, 2018 · 0 comments
Closed

VSCode chaining arrows #6

elfranne opened this issue Oct 19, 2018 · 0 comments

Comments

@elfranne
Copy link

elfranne commented Oct 19, 2018

Chaining arrows removes Syntax highlighting for VSCode.

image

Editor Name and Version: Microsoft VSCode 1.28.2
Theme: default
Document:

class puppet::editor::syntax{

 class this::is::fine{
   $var = 'this is fine'
 } ->
 class this::is::fine::too{
   $var2 = 'this is fine too'
 }
 -> class this::is::not::fine{
   $var3 = 'this is NOT fine'
 }
}
glennsarti added a commit to glennsarti/puppet-editor-syntax that referenced this issue Oct 25, 2018
Previously chaining arrows were not accounted for, which broke tokenization
after them.  This commit adds the correct patterns for the arrows.  The class
regex was changed as using `^` is incorrect, it should really be looking for
word boundaries.  This commit also adds tests for the chaining arrows.
jpogran pushed a commit that referenced this issue Oct 25, 2018
(GH-6) Correctly tokenize chaining arrows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant