(GH-6) Correctly tokenize chaining arrows #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously chaining arrows were not accounted for, which broke tokenization after them. This commit adds the correct patterns for the arrows. The class regex was changed as using `^` is incorrect, it should really be looking for word boundaries. This commit also adds tests for the chaining arrows.
|
Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously chaining arrows were not accounted for, which broke tokenization
after them. This commit adds the correct patterns for the arrows. The class
regex was changed as using
^is incorrect, it should really be looking forword boundaries. This commit also adds tests for the chaining arrows.
Fixes #6
Reminder
Added Tests
Ran
npm run convertand committed the changes too