Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESM dev entrypoint was causing unexpected behaviors #1059

Merged
merged 1 commit into from
May 18, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented May 11, 2021

Resolves #1003 and #1063 and probably some other's which I closed because didn't know this happened.

@vercel
Copy link

vercel bot commented May 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/BEKVUEhYQP3TEmhPAzTBGUiFuEGv
✅ Preview: https://js-lingui-git-fix-esm-issue-in-dev-mode-lingui-js.vercel.app

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.78 KB (0%)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.85 KB (0%)

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #1059 (0ee8604) into main (78ad09f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files          53       53           
  Lines        1624     1624           
  Branches      443      443           
=======================================
  Hits         1349     1349           
  Misses        158      158           
  Partials      117      117           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e9df5...0ee8604. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plural component requires extract string on each update
1 participant