Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert use useSyncExternalStore to subscribe for context updates #1755

Merged
merged 1 commit into from Aug 31, 2023

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Aug 31, 2023

This reverts commit 47d4fdb (#1746)

this closes #1754.

For now, this seems to be the best way to go about this, probably until facebook/react#26230 is released.

Description

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 9:49am

@vonovak vonovak changed the title Revert "refactor: use useSyncExternalStore to subscribe for context u… fix: revert use useSyncExternalStore to subscribe for context updates Aug 31, 2023
@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.76 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 2.21 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (87ffe72) 75.98% compared to head (325ce43) 75.95%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
- Coverage   75.98%   75.95%   -0.03%     
==========================================
  Files          81       81              
  Lines        2065     2063       -2     
  Branches      530      529       -1     
==========================================
- Hits         1569     1567       -2     
  Misses        383      383              
  Partials      113      113              
Files Changed Coverage Δ
packages/react/src/I18nProvider.tsx 91.30% <100.00%> (-0.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vonovak thank you!

@andrii-bodnar andrii-bodnar merged commit 4164893 into lingui:main Aug 31, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use-sync-external-store causes ERR_UNSUPPORTED_DIR_IMPORT error
2 participants