Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-extractor): fix ERR_IMPORT_ASSERTION_TYPE_MISSING issue #1775

Merged

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Oct 3, 2023

Description

Use fs.readFile instead of native import. Adding import assertion to the native import call currently not as easy because requires switching TS nodules compilation to esnext or node16 which is bringing a lot of issues.

fixes: #1771

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 8:50am

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.83 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.68 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e7a36d1) 76.26% compared to head (1d3732f) 76.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
- Coverage   76.26%   76.24%   -0.03%     
==========================================
  Files          81       81              
  Lines        2069     2071       +2     
  Branches      528      528              
==========================================
+ Hits         1578     1579       +1     
- Misses        379      380       +1     
  Partials      112      112              
Files Coverage Δ
...src/extract-experimental/buildExternalizeFilter.ts 78.57% <66.66%> (-4.77%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andrii-bodnar andrii-bodnar merged commit efcd405 into lingui:main Oct 3, 2023
13 of 14 checks passed
@thekip thekip deleted the fix/experimental-extractor-packagejson branch October 3, 2023 10:04
@yunsii
Copy link
Contributor

yunsii commented Oct 20, 2023

I want to try lingui extract-experimental, and still encounter this error. When this PR will be released?

@yunsii
Copy link
Contributor

yunsii commented Oct 20, 2023

I patched @lingui/cli to make it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After run lingui extract-experimental - TypeError [ERR_IMPORT_ASSERTION_TYPE_MISSING]
3 participants