Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspack now supports wasm plugins, lingui integration example could be improved #1896

Closed
thekip opened this issue Mar 28, 2024 · 3 comments · Fixed by #1923
Closed

rspack now supports wasm plugins, lingui integration example could be improved #1896

thekip opened this issue Mar 28, 2024 · 3 comments · Fixed by #1923

Comments

@thekip
Copy link
Collaborator

thekip commented Mar 28, 2024

https://www.rspack.dev/guide/builtin-swc-loader.html#optionsjscexperimentalplugins

Babel could be dropped, and swc-loader could b directly used with lingui swc plugin. Should result in a massive performance improvement.

@aseerkt
Copy link
Contributor

aseerkt commented Mar 30, 2024

I have tried rspack example with builtin:swc-loader instead of babel-loader and I am facing error.
swc_core version is incompatible between @lingui/swc-plugin and @rspack/core.

  • @linqui/swc-plugin@4.0.6 => swc_core 0.87.x
  • @rspack/core@0.5.8 => swc_core 0.88.x ~ 0.89x

The error I am facing can be found here in this thread
We will need to upgrade swc_core version in range 0.88x ~ 0.89.x for @lingui/swc-plugin as mentioned here.

Screenshot from 2024-03-30 19-32-11

@thekip
Copy link
Collaborator Author

thekip commented Apr 2, 2024

Thanks for taking into this. Yes, currently this is expected, the version with newer swc_core is not ready yet from our side.

I'm aligning version bump with NextJS releases (since it's a most popular framework used with lingui / swc) and NextJS is still hanging on the older version.

@thekip
Copy link
Collaborator Author

thekip commented Apr 18, 2024

This one could be continued, swc-plugin released with newer version of swc-core https://github.com/lingui/swc-plugin/releases/tag/4.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants