# is being replaced by%__lingui_octothorpe__% outside plural and selectordinal

[dan-dr]

Describe the bug
Given a regular messages that has # in it , when trying to display the message it is replaced with %__lingui_octothorpe__%

EDIT: it seems to happen only if the translated message starts with #

To Reproduce

import { Trans } from "@lingui/macro"

export default function App() {
   return <Trans>#{standing} in leaderboard</Trans>
}

Resulting in po:

msgid "#{standing} in the leaderboard"
msgstr "#{standing} in the leaderboard"

Expected behavior
#7 in leaderboard

Actual result
%__lingui_octothorpe__%7 in leaderboard

Additional context
Add any other context about the problem here.

• jsLingui version 4.7.1
• Babel version 7.12.3 (i think, CRA)
• Macro support:
• I'm using SWC with @lingui/swc-plugin
• I'm using Babel with babel-macro-plugin
• I'm not using macro
• Create React App

[dan-dr]

I'm guessing it's

js-lingui/packages/core/src/interpolate.ts

Line 84 in 133a6e9

if (token === "#") {

[dan-dr]

I narrowed it, the bug seems to occur only when the translation starts with # followed by variable.

EDIT: found more test cases that fail
It seems to happen whenever # is tokenized by itself (I think it only happens when it's next to a variable)

Here's a test case for i18n.test.ts:

it("._ should not bug when with #", () => {
    const messages = {
      Bad: "#{standing} in leaderboard",
      BadToo: "leaderboard standing is {standing}#",
      BadTooToo: "your id is {name}#{tag}",
      Good: "# standing in leaderboard",
      GoodToo: "standing is #{standing} in leaderboard",
      GoodTooToo: "leaderboard standing is #{standing}",
    }

    const i18n = setupI18n({
      locale: "en",
      messages: { en: messages },
    })
    expect(i18n._({ id: "Bad", values: { standing: 7 } })).toEqual(
      "#7 in leaderboard"
    )
    expect(i18n._({ id: "BadToo", values: { standing: 7 } })).toEqual(
      "leaderboard standing is 7#"
    )
    expect(
      i18n._({ id: "BadTooToo", values: { name: "hey", tag: "you" } })
    ).toEqual("your id is hey#you")
    expect(i18n._({ id: "Good", values: { standing: 7 } })).toEqual(
      "# standing in leaderboard"
    )
    expect(i18n._({ id: "GoodToo", values: { standing: 7 } })).toEqual(
      "standing is #7 in leaderboard"
    )
    expect(i18n._({ id: "GoodTooToo", values: { standing: 7 } })).toEqual(
      "leaderboard standing is #7"
    )
  })

[thekip]

it seems there is an issue in message format parser, it shouldn't treat '#' symbol as octothorpe outside { } expressions. Anyway, thanks for digging it and fixing.