-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Move typescript dependency to peer #589
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). |
Deployment failed with the following error:
|
Thank you @FredyC! I'm gonna release it tonight. |
Hello :) when is this going to be deployed to npm? |
@tricoder42 Any way this can be released? Thanks! Also, is this something you'd be open to porting over to the |
@crhayes Uh, the |
@FredyC Good to know, my bad! |
@tricoder42 You haven't mentioned this PR in the release, is it included? |
@tricoder42 Oh, yeah, it is! I missed that because it has different commit message format. |
It has just been released in 2.9.0. ;) |
With TS 3.7 the new syntax for optional chaining and nullish coalescing is added. Because cli depends on TS 2.9.2, it's not able to parse it. I think that moving TS as peer dependency is a safe option here. I did not dare to update in devDependencies, but it's unlikely it would break anything.