Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Move typescript dependency to peer #589

Merged
merged 1 commit into from
Nov 18, 2019
Merged

[cli] Move typescript dependency to peer #589

merged 1 commit into from
Nov 18, 2019

Conversation

danielkcz
Copy link
Contributor

With TS 3.7 the new syntax for optional chaining and nullish coalescing is added. Because cli depends on TS 2.9.2, it's not able to parse it. I think that moving TS as peer dependency is a safe option here. I did not dare to update in devDependencies, but it's unlikely it would break anything.

@vercel
Copy link

vercel bot commented Nov 14, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@vercel vercel bot requested a deployment to staging November 14, 2019 13:05 Abandoned
@vercel
Copy link

vercel bot commented Nov 14, 2019

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

@tricoder42 tricoder42 merged commit 5c6ece1 into lingui:master Nov 18, 2019
@tricoder42
Copy link
Contributor

Thank you @FredyC! I'm gonna release it tonight.

@danielkcz danielkcz deleted the patch-1 branch November 18, 2019 11:52
@arikaa
Copy link

arikaa commented Nov 25, 2019

Hello :) when is this going to be deployed to npm?

@crhayes
Copy link

crhayes commented Nov 28, 2019

@tricoder42 Any way this can be released? Thanks!

Also, is this something you'd be open to porting over to the 2.* release branch? Would be nice to be able to use the stable 2.* releases with these new Typescript 3.7 features.

@danielkcz
Copy link
Contributor Author

@crhayes Uh, the master branch is 2.x, or I hope since I am still using that as well :) The next is for V3

@crhayes
Copy link

crhayes commented Nov 29, 2019

@FredyC Good to know, my bad!

@danielkcz
Copy link
Contributor Author

@tricoder42 You haven't mentioned this PR in the release, is it included?

@tricoder42
Copy link
Contributor

@tricoder42 Oh, yeah, it is! I missed that because it has different commit message format.

@tricoder42
Copy link
Contributor

It has just been released in 2.9.0. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants