Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatters exceptions throw error #889

Merged
merged 1 commit into from Nov 26, 2020
Merged

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Nov 25, 2020

Will close #888

@vercel
Copy link

vercel bot commented Nov 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/j4iz4rhzh
✅ Preview: https://js-lingui-git-fix-exception-bad-file.lingui-js.now.sh

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #889 (9eeec5b) into main (b8280a0) will increase coverage by 0.17%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   82.91%   83.08%   +0.17%     
==========================================
  Files          51       51              
  Lines        1440     1437       -3     
  Branches      395      395              
==========================================
  Hits         1194     1194              
+ Misses        145      142       -3     
  Partials      101      101              
Impacted Files Coverage Δ
packages/cli/src/api/formats/csv.ts 78.94% <0.00%> (+3.94%) ⬆️
packages/cli/src/api/formats/lingui.ts 90.90% <0.00%> (+7.57%) ⬆️
packages/cli/src/api/formats/minimal.ts 27.27% <0.00%> (+2.27%) ⬆️
packages/cli/src/api/formats/po.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8280a0...9eeec5b. Read the comment docs.

Copy link
Contributor

@tricoder42 tricoder42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Good job hunting down this bug 👍

@tricoder42 tricoder42 merged commit d6b774c into main Nov 26, 2020
@semoal semoal deleted the fix-exception-bad-file branch January 13, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lingui Extract Erases All Messages when JSON is Invalid
2 participants