Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added return types to functions returned by interpolate and context in core/cjs/context.ts #922

Merged
merged 1 commit into from Jan 13, 2021

Conversation

gitschwifty
Copy link
Contributor

Should fix issue #921 i18n._ now shows a string return type according to typescript tooltips in vscode

@vercel
Copy link

vercel bot commented Dec 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/ftvv9zztx
✅ Preview: https://js-lingui-git-fork-gitschwifty-main.lingui-js.vercel.app

@gitschwifty gitschwifty changed the title added return types to functions returned by interpolate and context in core/cjs/context.ts fix: added return types to functions returned by interpolate and context in core/cjs/context.ts Dec 29, 2020
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #922 (3cec131) into main (3afacec) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files          52       52           
  Lines        1571     1571           
  Branches      426      426           
=======================================
  Hits         1308     1308           
  Misses        156      156           
  Partials      107      107           
Impacted Files Coverage Δ
packages/core/src/context.ts 86.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afacec...3cec131. Read the comment docs.

@semoal
Copy link
Contributor

semoal commented Jan 13, 2021

in v3, it's recommeded to just use t`` macro, you don't need i18n._ for practically anything 👍🏻 anyways returning string i think it's better than any

@semoal semoal merged commit 249c486 into lingui:main Jan 13, 2021
@semoal
Copy link
Contributor

semoal commented Jan 13, 2021

Released in 3.4.0 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants