Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compilerBabelOptions jest-validate #938

Merged
merged 1 commit into from Jan 13, 2021
Merged

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Jan 13, 2021

Will close #935

unfortunately jest-validate doesn't work if in the example config we set an empty object, we must strict declare the values we accept. I'll setup the default values that we're using and probably the only ones that the final user should be able to change.. Dunno

@vercel
Copy link

vercel bot commented Jan 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/28rqo9gzl
✅ Preview: https://js-lingui-git-fix-compiler-options-type.lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #938 (3ab2e2c) into main (249c486) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files          52       52           
  Lines        1571     1571           
  Branches      426      426           
=======================================
  Hits         1308     1308           
  Misses        156      156           
  Partials      107      107           
Impacted Files Coverage Δ
packages/cli/src/api/compile.ts 100.00% <ø> (ø)
packages/conf/src/index.ts 87.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249c486...3ab2e2c. Read the comment docs.

@semoal semoal merged commit 087ec1f into main Jan 13, 2021
@semoal semoal deleted the fix-compiler-options-type branch January 13, 2021 19:26
@semoal
Copy link
Contributor Author

semoal commented Jan 13, 2021

Released in 3.4.0 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings for compilerBabelOptions other than empty.
1 participant