Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TS based Lingui configuration #941

Merged
merged 1 commit into from Jan 13, 2021

Conversation

danielkcz
Copy link
Contributor

Fixes #940

In the end, I've included @endemolshinegroup/cosmiconfig-typescript-loader as a dependency to consume the Error class from it so it doesn't need to be copied too. In case the EndemolShineGroup/cosmiconfig-typescript-loader#132 gets merged & published, the code here can be simplified.

@vercel
Copy link

vercel bot commented Jan 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/hafrhns6f
✅ Preview: https://js-lingui-git-fork-fredyc-conf-typescript-support.lingui-js.now.sh

@danielkcz danielkcz changed the title Support for TS config Support for TS based Lingui configuration Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #941 (45676c9) into main (249c486) will decrease coverage by 0.30%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   83.25%   82.95%   -0.31%     
==========================================
  Files          52       52              
  Lines        1571     1578       +7     
  Branches      426      426              
==========================================
+ Hits         1308     1309       +1     
- Misses        156      162       +6     
  Partials      107      107              
Impacted Files Coverage Δ
packages/conf/src/index.ts 80.51% <22.22%> (-6.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249c486...45676c9. Read the comment docs.

@semoal semoal merged commit 8631111 into lingui:main Jan 13, 2021
@semoal
Copy link
Contributor

semoal commented Jan 13, 2021

Great Daniel, thanks for your contribution, i'm polishing some pending issues and we'll release a new version with this feature introduced :)

@danielkcz danielkcz deleted the conf-typescript-support branch January 13, 2021 19:07
@semoal
Copy link
Contributor

semoal commented Jan 13, 2021

Released in 3.4.0 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable TypeScript based config
2 participants