Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defaultComponent typing #953

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Jan 21, 2021

not sure why this is not picked up in tests, but I believe the typing is wrong here. I might be wrong here but I tested locally and it seems fine

BTW I noticed that when running the code through prettier, it comes up with many more changes, the prettier config is probably not followed...

@vercel
Copy link

vercel bot commented Jan 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/c4abb9fry
✅ Preview: https://js-lingui-git-fork-vonovak-fix-defaultcomponent-typing.lingui-js.now.sh

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #953 (2e1bf59) into main (96bd31b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files          53       53           
  Lines        1600     1600           
  Branches      428      428           
=======================================
  Hits         1336     1336           
  Misses        154      154           
  Partials      110      110           
Impacted Files Coverage Δ
packages/react/src/I18nProvider.tsx 83.87% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96bd31b...2e1bf59. Read the comment docs.

@vonovak vonovak changed the title Fix defaultComponent typing fix: defaultComponent typing Jan 21, 2021
@semoal semoal merged commit 6b08dd3 into lingui:main Jan 25, 2021
@semoal
Copy link
Contributor

semoal commented Jan 25, 2021

Thanks mate!

@vonovak vonovak deleted the fix/defaultComponent-typing branch January 25, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants