Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No message when translations are missing #964

Merged
merged 2 commits into from Jan 27, 2021

Conversation

HamAndRock
Copy link
Contributor

Hello,
I stumble upon this issue quite frequently, sometimes someone at team accidentally deletes a string in one of translations files and it throws a generic error.

Error:
image

I saw your if check few lines before the crashing point, hovewer that if won't catch it so I moved it to correct scope.

My fix results into this:

image

@vercel
Copy link

vercel bot commented Jan 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/lnmju83ro
✅ Preview: https://js-lingui-git-fork-hamandrock-hamandrock-patch-1.lingui-js.now.sh

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #964 (24efb86) into main (f368b35) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
- Coverage   83.51%   83.35%   -0.16%     
==========================================
  Files          53       53              
  Lines        1601     1604       +3     
  Branches      428      429       +1     
==========================================
  Hits         1337     1337              
- Misses        154      156       +2     
- Partials      110      111       +1     
Impacted Files Coverage Δ
packages/cli/src/api/catalog.ts 82.54% <0.00%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f368b35...24efb86. Read the comment docs.

@landsman
Copy link
Contributor

I thought that this was resolved here: #545 but it's not I see.

@semoal semoal merged commit 14f24f2 into lingui:main Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants