Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve component prop on Trans #94

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: preserve component prop on Trans #94

merged 1 commit into from
May 30, 2024

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented May 30, 2024

It's a prop accepted by Trans: https://lingui.dev/ref/react#local-configuration

thekip
thekip approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@thekip thekip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have no idea how people use it, but it's fine. I've checked that typings for Trans macro also exposing this prop, so this is good to go.

@vonovak
Copy link
Contributor Author

vonovak commented May 30, 2024

It's just an alternative to using the render callback. We could probably remove one of the two but it'd be breaking. Maybe some other time 🙂

@thekip thekip merged commit c318352 into lingui:main May 30, 2024
2 checks passed
@andrii-bodnar
Copy link
Contributor

@vonovak available in 4.0.8

@vonovak vonovak deleted the fix/preserve-component branch May 30, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekip thekip thekip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vonovak @andrii-bodnar @thekip