LBaaS v2 l7 policy support - part 3: get l7policy

For gophercloud#832

Neutron-LBaaS l7 policy get API implementation:
https://github.com/openstack/neutron-lbaas/blob/8e8a6c47c7d38fa7b61850ff9ea2cf130718ded3/neutron_lbaas/services/loadbalancer/plugin.py#L971

Octavia l7 policy get API implementation:
https://github.com/openstack/octavia/blob/54a4cf00cf304b108013ca4487c138c13f30983d/octavia/api/v2/controllers/l7policy.py#L47

acceptance/openstack/loadbalancer/v2/loadbalancers_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/gophercloud/gophercloud/acceptance/clients"
 	networking "github.com/gophercloud/gophercloud/acceptance/openstack/networking/v2"
 	"github.com/gophercloud/gophercloud/acceptance/tools"
+	"github.com/gophercloud/gophercloud/openstack/loadbalancer/v2/l7policies"
 	"github.com/gophercloud/gophercloud/openstack/loadbalancer/v2/listeners"
 	"github.com/gophercloud/gophercloud/openstack/loadbalancer/v2/loadbalancers"
 	"github.com/gophercloud/gophercloud/openstack/loadbalancer/v2/monitors"
@@ -101,11 +102,18 @@ func TestLoadbalancersCRUD(t *testing.T) {
 	tools.PrintResource(t, newListener)
 
 	// L7 policy
-	_, err = CreateL7Policy(t, lbClient, listener, lb)
+	policy, err := CreateL7Policy(t, lbClient, listener, lb)
 	if err != nil {
 		t.Fatalf("Unable to create l7 policy: %v", err)
 	}
 
+	newPolicy, err := l7policies.Get(lbClient, policy.ID).Extract()
+	if err != nil {
+		t.Fatalf("Unable to get l7 policy: %v", err)
+	}
+
+	tools.PrintResource(t, newPolicy)
+
 	// Pool
 	pool, err := CreatePool(t, lbClient, lb)
 	if err != nil {

openstack/loadbalancer/v2/l7policies/doc.go

@@ -1,23 +1,26 @@
 /*
 Package l7policies provides information and interaction with L7Policies and
 Rules of the LBaaS v2 extension for the OpenStack Networking service.
+
 Example to Create a L7Policy
+
 	createOpts := l7policies.CreateOpts{
 		Name:        "redirect-example.com",
 		ListenerID:  "023f2e34-7806-443b-bfae-16c324569a3d",
 		Action:      l7policies.ActionRedirectToURL,
 		RedirectURL: "http://www.example.com",
 	}
-	l7policy, err := l7policies.Create(networkClient, createOpts).Extract()
+	l7policy, err := l7policies.Create(lbClient, createOpts).Extract()
 	if err != nil {
 		panic(err)
 	}
 
 Example to List L7Policies
+
 	listOpts := l7policies.ListOpts{
 		ListenerID: "c79a4468-d788-410c-bf79-9a8ef6354852",
 	}
-	allPages, err := l7policies.List(networkClient, listOpts).AllPages()
+	allPages, err := l7policies.List(lbClient, listOpts).AllPages()
 	if err != nil {
 		panic(err)
 	}
@@ -28,5 +31,12 @@ Example to List L7Policies
 	for _, l7policy := range allL7Policies {
 		fmt.Printf("%+v\n", l7policy)
 	}
+
+Example to Get a L7Policy
+
+	l7policy, err := l7policies.Get(lbClient, "023f2e34-7806-443b-bfae-16c324569a3d").Extract()
+	if err != nil {
+		panic(err)
+	}
 */
 package l7policies

openstack/loadbalancer/v2/l7policies/requests.go

@@ -131,3 +131,9 @@ func List(c *gophercloud.ServiceClient, opts ListOptsBuilder) pagination.Pager {
 		return L7PolicyPage{pagination.LinkedPageBase{PageResult: r}}
 	})
 }
+
+// Get retrieves a particular l7policy based on its unique ID.
+func Get(c *gophercloud.ServiceClient, id string) (r GetResult) {
+	_, r.Err = c.Get(resourceURL(c, id), &r.Body, nil)
+	return
+}

openstack/loadbalancer/v2/l7policies/results.go

@@ -129,3 +129,9 @@ func ExtractL7Policies(r pagination.Page) ([]L7Policy, error) {
 	err := (r.(L7PolicyPage)).ExtractInto(&s)
 	return s.L7Policies, err
 }
+
+// GetResult represents the result of a Get operation. Call its Extract
+// method to interpret the result as a L7Policy.
+type GetResult struct {
+	commonResult
+}

openstack/loadbalancer/v2/l7policies/testing/fixtures.go

@@ -131,3 +131,14 @@ func HandleL7PolicyListSuccessfully(t *testing.T) {
 		}
 	})
 }
+
+// HandleL7PolicyGetSuccessfully sets up the test server to respond to a l7policy Get request.
+func HandleL7PolicyGetSuccessfully(t *testing.T) {
+	th.Mux.HandleFunc("/v2.0/lbaas/l7policies/8a1412f0-4c32-4257-8b07-af4770b604fd", func(w http.ResponseWriter, r *http.Request) {
+		th.TestMethod(t, r, "GET")
+		th.TestHeader(t, r, "X-Auth-Token", client.TokenID)
+		th.TestHeader(t, r, "Accept", "application/json")
+
+		fmt.Fprintf(w, SingleL7PolicyBody)
+	})
+}

openstack/loadbalancer/v2/l7policies/testing/requests_test.go

@@ -84,3 +84,17 @@ func TestListAllL7Policies(t *testing.T) {
 	th.CheckDeepEquals(t, L7PolicyToURL, actual[0])
 	th.CheckDeepEquals(t, L7PolicyToPool, actual[1])
 }
+
+func TestGetL7Policy(t *testing.T) {
+	th.SetupHTTP()
+	defer th.TeardownHTTP()
+	HandleL7PolicyGetSuccessfully(t)
+
+	client := fake.ServiceClient()
+	actual, err := l7policies.Get(client, "8a1412f0-4c32-4257-8b07-af4770b604fd").Extract()
+	if err != nil {
+		t.Fatalf("Unexpected Get error: %v", err)
+	}
+
+	th.CheckDeepEquals(t, L7PolicyToURL, *actual)
+}

openstack/loadbalancer/v2/l7policies/urls.go

@@ -10,3 +10,7 @@ const (
 func rootURL(c *gophercloud.ServiceClient) string {
 	return c.ServiceURL(rootPath, resourcePath)
 }
+
+func resourceURL(c *gophercloud.ServiceClient, id string) string {
+	return c.ServiceURL(rootPath, resourcePath, id)
+}