LBaaS v2 l7 policy support [Part 4]: delete l7policy

For gophercloud#832

Neutron-LBaaS l7 policy delete API implementation:
https://github.com/openstack/neutron-lbaas/blob/8e8a6c47c7d38fa7b61850ff9ea2cf130718ded3/neutron_lbaas/services/loadbalancer/plugin.py#L954

Octavia l7 policy delete API implementation:
https://github.com/openstack/octavia/blob/54a4cf00cf304b108013ca4487c138c13f30983d/octavia/api/v2/controllers/l7policy.py#L253

acceptance/openstack/networking/v2/extensions/lbaas_v2/lbaas_v2.go

@@ -202,6 +202,23 @@ func CreateL7Policy(t *testing.T, client *gophercloud.ServiceClient, listener *l
 	return policy, nil
 }
 
+// DeleteL7Policy will delete a specified l7 policy. A fatal error will occur if
+// the l7 policy could not be deleted. This works best when used as a deferred
+// function.
+func DeleteL7Policy(t *testing.T, client *gophercloud.ServiceClient, lbID, policyID string) {
+	t.Logf("Attempting to delete l7 policy %s", policyID)
+
+	if err := l7policies.Delete(client, policyID).ExtractErr(); err != nil {
+		t.Fatalf("Unable to delete l7 policy: %v", err)
+	}
+
+	if err := WaitForLoadBalancerState(client, lbID, "ACTIVE", loadbalancerActiveTimeoutSeconds); err != nil {
+		t.Fatalf("Timed out waiting for loadbalancer to become active")
+	}
+
+	t.Logf("Successfully deleted l7 policy %s", policyID)
+}
+
 // DeleteListener will delete a specified listener. A fatal error will occur if
 // the listener could not be deleted. This works best when used as a deferred
 // function.

acceptance/openstack/networking/v2/extensions/lbaas_v2/loadbalancers_test.go

@@ -101,6 +101,7 @@ func TestLoadbalancersCRUD(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Unable to create l7 policy: %v", err)
 	}
+	defer DeleteL7Policy(t, client, policy.ID)
 
 	newPolicy, err := l7policies.Get(client, policy.ID).Extract()
 	if err != nil {

openstack/networking/v2/extensions/lbaas_v2/l7policies/doc.go

@@ -42,5 +42,13 @@ Example to Get a L7Policy
 	if err != nil {
 		panic(err)
 	}
+
+Example to Delete a L7Policy
+
+	l7policyID := "d67d56a6-4a86-4688-a282-f46444705c64"
+	err := l7policies.Delete(networkClient, l7policyID).ExtractErr()
+	if err != nil {
+		panic(err)
+	}
 */
 package l7policies

openstack/networking/v2/extensions/lbaas_v2/l7policies/requests.go

@@ -137,3 +137,9 @@ func Get(c *gophercloud.ServiceClient, id string) (r GetResult) {
 	_, r.Err = c.Get(resourceURL(c, id), &r.Body, nil)
 	return
 }
+
+// Delete will permanently delete a particular l7policy based on its unique ID.
+func Delete(c *gophercloud.ServiceClient, id string) (r DeleteResult) {
+	_, r.Err = c.Delete(resourceURL(c, id), nil)
+	return
+}

openstack/networking/v2/extensions/lbaas_v2/l7policies/results.go

@@ -135,3 +135,9 @@ func ExtractL7Policies(r pagination.Page) ([]L7Policy, error) {
 type GetResult struct {
 	commonResult
 }
+
+// DeleteResult represents the result of a Delete operation. Call its
+// ExtractErr method to determine if the request succeeded or failed.
+type DeleteResult struct {
+	gophercloud.ErrResult
+}

openstack/networking/v2/extensions/lbaas_v2/l7policies/testing/fixtures.go

@@ -142,3 +142,13 @@ func HandleL7PolicyGetSuccessfully(t *testing.T) {
 		fmt.Fprintf(w, SingleL7PolicyBody)
 	})
 }
+
+// HandleL7PolicyDeletionSuccessfully sets up the test server to respond to a l7policy deletion request.
+func HandleL7PolicyDeletionSuccessfully(t *testing.T) {
+	th.Mux.HandleFunc("/v2.0/lbaas/l7policies/8a1412f0-4c32-4257-8b07-af4770b604fd", func(w http.ResponseWriter, r *http.Request) {
+		th.TestMethod(t, r, "DELETE")
+		th.TestHeader(t, r, "X-Auth-Token", client.TokenID)
+
+		w.WriteHeader(http.StatusNoContent)
+	})
+}

openstack/networking/v2/extensions/lbaas_v2/l7policies/testing/requests_test.go

@@ -98,3 +98,12 @@ func TestGetL7Policy(t *testing.T) {
 
 	th.CheckDeepEquals(t, L7PolicyToURL, *actual)
 }
+
+func TestDeleteL7Policy(t *testing.T) {
+	th.SetupHTTP()
+	defer th.TeardownHTTP()
+	HandleL7PolicyDeletionSuccessfully(t)
+
+	res := l7policies.Delete(fake.ServiceClient(), "8a1412f0-4c32-4257-8b07-af4770b604fd")
+	th.AssertNoErr(t, res.Err)
+}