Fix comparison logic in Int.Cmp to correctly handle 0 and -0 (#11)

linhbkhn95 · May 20, 2024 · d7d8d5a · d7d8d5a
1 parent 8537a3d
commit d7d8d5a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/int256.go b/int256.go
@@ -235,6 +235,8 @@ func (z *Int) Cmp(x *Int) (r int) {
 		if z.neg {
 			r = -r
 		}
+	case z.abs.IsZero() && x.abs.IsZero():
+		r = 0
 	case z.neg:
 		r = -1
 	default:

diff --git a/int256_test.go b/int256_test.go
@@ -1396,6 +1396,19 @@ func TestInt_Cmp(t *testing.T) {
 			},
 			wantR: 1,
 		},
+		{
+			name: "Should return correct value",
+			fields: fields{
+				abs: uint256.NewInt(0),
+				neg: true,
+			},
+			args: args{
+				x: &Int{
+					abs: uint256.NewInt(0),
+				},
+			},
+			wantR: 0,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {