added(*): Implmented And and Or operations using uint256 package #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pull request implement "And" and "Or" operations using only "uint256" package and not replaying on "math.big".
The test passed for me and it seems correct. Howerever I might be wrong :)
Just a side note, even on the "math.big" package there this logical expression:
// x | (-y) == x | ^(y-1) == ^((y-1) &^ x) == -(^((y-1) &^ x) + 1)
However the least part (that is " -(^((y-1) &^ x) + 1)"), I suspect that is wrong, the correct should be, from my understanding, '"-(((y-1) &^ x) + 1)" i.e without the "not" operator in the begining. What make me also believe that it is only a typo is that this corrected expresion without the "not" operator in the begining is exactly what is implmented in "math.big" package.
Anyways, I followed closely what is implemented in "math.big" in my pull request.