-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript engine missing! #26
Comments
Update: When I set js_path: "{{ Gem::lib_path }}/assets/js" in master and development , build failed for both! links to full build log: interesting that error message is different. I removed js_path from both branches _config.yml. master - https://gitlab.com/Azadeh-Afzar/Web-Development/Kianic-Jekyll-Theme/-/jobs/284988532 master failed and development succeed! I don't know whats wrong here ... |
now I feel I'm stupid! I just downloaded katex.min.js from your repo, and placed it inside my Jekyll theme repo So I've started to read you actual source code to find out both js_filename and js_path, I understood that katex in _config.yml is optional because you have already hard coded them into source code and it will call a merge function to fetch user settings from _config.yml. After reading error messages it's clear that problem isn't katex because it's not producing the ones you have set in source codes. but why development succeed and master failed? I found it in a hard way (my stupid self)
You may want to test this yourself and add it to katex documentation in future. |
Thanks for a very detailed report! To clarify, Jekyll is not dependent on The engine is selected by the I have it on my long list of TODOs to embed a javascript engine and stop using I think the problems you ran into are indeed confusing and maybe I can find just a little time to clarify in docs/errors. I'll also try to figure out why it was working on Other suggestions appreciated. |
Hi,
I already know why it was working on dev and failed on master.
Dev branch has a ci job to push the site to surge.sh. So basically it has a
command to install node.js which is necessary for surge before going to
“bundle exec jekyll build”, thus everything was ok on dev branch
But in master, the job was just to build site for gitlab pages without any
node.js installation. and that causes this painful confusion for me, I
figured out it also needs node.js too :)
On Tue, Sep 3, 2019 at 11:15 PM Jerry Lin ***@***.***> wrote:
Thanks for a very detailed report!
To clarify, Jekyll is not dependent on node.js at all, but it's this
jekyll-katex plugin that requires some kind of JS engine which can either
be rhino, node, or some other. Since KaTeX is fully written in JS, it's
hard to get around this.
The engine is selected by the execjs gem and the original error you got
was due to a failure to find a JS execution engine.
I have it on my long list of TODOs to embed a javascript engine and stop
using execjs (appears unmaintained) so users do not need to provide one
and it allows for a more consistent/robust experience. I did not add the JS
engine requirement to the docs because it's common for most systems to have
an engine installed somewhere and I hope to remove this requirement.
I think the problems you ran into are indeed confusing and maybe I can
find just a little time to clarify in docs/errors. I'll also try to figure
out why it was working on master and not on a dev branch.
Other suggestions appreciated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26?email_source=notifications&email_token=ADIMIGB4WRWVJAQZRQCXAKDQH2WD3A5CNFSM4ISWRIV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZFUFY#issuecomment-527587863>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADIMIGGQJJJRNY4GYCUX2PDQH2WD3ANCNFSM4ISWRIVQ>
.
--
<https://about.me/mahdibaghbani?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb>
Mahdi Baghbani
about.me/mahdibaghbani
<https://about.me/mahdibaghbani?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb>
|
Hi, first of all thanks for this plugin and please add support for Jekyll 4.0 :)
and now the actual issue:
I'm building Jekyll in a gitlab ci-cd for 1 project that has two branches: master and development
they have same katex config but in master I get this error
while on development branch everything runs just fine:
can you look at this? i'm really confused and used many ways to solve it but still failed.
thank you
The text was updated successfully, but these errors were encountered: