Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to stop overwriting the official 'rake' executable when installing this gem. #40

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

0x1eef
Copy link
Contributor

@0x1eef 0x1eef commented Aug 26, 2019

This gem overwrites the official rake executable when it is installed through Bundler. The rake executable from this gem requires Bundler to work and breaks when outside a Bundler project. Besides, your gem should not be overwriting the executables of other gems.

Please consider this pull request or devise your own solution that doesn't install a broken rake when this gem is installed through Bundler.

I have also opened an issue on the Bundler tracker asking to do the same as rubygems by showing a confirmation prompt in case a gem like this one overwrites the executable from another gem.

'rake' executable from the official 'rake' gem when installing this gem through Bundler.
@coveralls
Copy link

coveralls commented Aug 26, 2019

Coverage Status

Coverage remained the same at 99.348% when pulling b8837ff on rg-3:master into 8bf8f8c on linjunpop:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.351% when pulling b8837ff on rg-3:master into 8bf8f8c on linjunpop:master.

@linjunpop
Copy link
Owner

Many thanks.

@linjunpop linjunpop merged commit fc1221e into linjunpop:master Aug 26, 2019
@0x1eef
Copy link
Contributor Author

0x1eef commented Aug 27, 2019

Thanks Jun Lin. Do you know when we can expect a new release?

@linjunpop
Copy link
Owner

Hi @rg-3, https://rubygems.org/gems/riif/versions/0.9.0 released.

@0x1eef
Copy link
Contributor Author

0x1eef commented Aug 27, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants