Tideways support #77
Open
Tideways support #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed preferredProfilerAdapters to possibleProfilerAdapters
… functions from profilertest where those were removed
|
Turns out this whole MongoDB persistence layer needs porting from |
…of it's classes are now final and the old inheritance workaround therefore does not work. Put used functions in MongoClientInterface
…st function is ongoing
…nd a whole load of TODO's where I ported the original functionality and saw spots with potential pain points
…rcane little chunks of logic into separate functions that accept a ProfileInterface and made it use MongoClientInterface's insert function
|
I actually do not understand what the issue is with Scrutinizer - @dennisdegreef do you have any idea how I can see what the problem is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProfilerAdapter4.8.28, as otherwise the error messages can be weird sometimes.The tests pass on my machine except for the mongodb stuff, which is because I don't have the libraries. The error is thus:
Error: Class 'MongoDate' not found