Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fails to work with newer requests releases #76

Closed
anarcat opened this issue Jun 27, 2017 · 0 comments
Closed

fails to work with newer requests releases #76

anarcat opened this issue Jun 27, 2017 · 0 comments

Comments

@anarcat
Copy link
Contributor

anarcat commented Jun 27, 2017

as partially described in #74, linkchecker seems to fail when using requests releases newer than 2.15. here's a backtrace:

  File "/usr/lib/python2.7/site-packages/linkcheck/checker/httpurl.py", line 197, in _get_ssl_sock
    line: if raw_connection.sock is None:
    locals:
      raw_connection = <local> None
      raw_connection.sock = <local> !AttributeError: 'NoneType' object has no attribute 'sock'
      None = <builtin> None
AttributeError: 'NoneType' object has no attribute 'sock'
@anarcat anarcat mentioned this issue Jun 27, 2017
Closed
@jdgoettsch jdgoettsch mentioned this issue Aug 21, 2017
Closed
anarcat added a commit to anarcat/linkchecker that referenced this issue Oct 3, 2017
@anarcat
workaround new limitation in requests
9b12b5d 
newer requests do not expose the internal SSL socket object so we
cannot verify certificates. there was work to allow custom
verification routines which we could use, but this never finished:

urllib3/urllib3#257

so right now, just treat missing socket information as if the cert was
missing.

Closes: linkchecker#76
@anarcat anarcat mentioned this issue Oct 3, 2017
Merged
@anarcat anarcat mentioned this issue Apr 23, 2018
Closed
@anarcat anarcat mentioned this issue Jun 3, 2018
Closed
@anarcat anarcat mentioned this issue Jun 21, 2018
Closed
@cipherboy cipherboy mentioned this issue Jul 26, 2018
Merged
@mgedmin mgedmin mentioned this issue Apr 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anarcat