Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum Requests version to 2.20 #704

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Dec 2, 2022

Add pdfminer.six to minimum version testing

@mgedmin
Copy link
Contributor

mgedmin commented Dec 3, 2022

What's with the docs failures?

WARNING: [autosummary] failed to import linkcheck.checker.
Possible hints:
* AttributeError: module 'lib' has no attribute 'X509_V_FLAG_CB_ISSUER_CHECK'
* ImportError: 
* AttributeError: module 'linkcheck' has no attribute 'checker'

@cjmayo cjmayo force-pushed the requests220 branch 3 times, most recently from 110536d to 76aedef Compare December 3, 2022 17:15
@cjmayo
Copy link
Contributor Author

cjmayo commented Dec 3, 2022

docs uses requirements.txt, adding pdfminer.six here then meant it pulled in cryptography, but cryptography >= 38 breaks pyOpenSSL < 22 by removing that X509_V_FLAG_CB_ISSUER_CHECK: pyca/pyopenssl@d290855 and Ubuntu 20.04 only has 19.0.0 (the other jobs get pyOpenSSL upgraded by tox.ini because it is used directly in the tests).

ubuntu-latest was meant to have been updated to 22.04 a few days ago, https://github.blog/changelog/2022-12-01-github-actions-larger-runners-using-ubuntu-latest-label-will-now-use-ubuntu-22-04/. But not seeing that here, so I have changed the docs job to explicitly use ubuntu-22.04.

Couple of other changes:

  • I had originally set the minimum pdfminer.six to 20181108 but changed it to 20191020 while experimenting with the docs problem. Put it back to 20181108. That is the same as Debian oldstable.
  • Added pdfminer.six to the list of packages in install.txt for a manual setup.

20181108 is the version used by the current Debian oldstable.
Ubuntu 20.04 LTS has 20191020.

pdfminer installs cryptography, >= 38 breaks pyOpenSSL < 22 as found in
Ubuntu 20.04 LTS. Update docs job to use ubuntu-22.04 to avoid
failures.
@cjmayo cjmayo merged commit 1d7175f into linkchecker:master Dec 5, 2022
github-actions bot pushed a commit that referenced this pull request Dec 5, 2022
Increase minimum Requests version to 2.20 1d7175f
@cjmayo cjmayo deleted the requests220 branch December 5, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants