Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/76 #77

Merged
merged 4 commits into from
Oct 3, 2020
Merged

Issues/76 #77

merged 4 commits into from
Oct 3, 2020

Conversation

goofballLogic
Copy link
Member

Closes #76

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   68.59%   68.59%           
=======================================
  Files          22       22           
  Lines        4053     4053           
  Branches     1028     1028           
=======================================
  Hits         2780     2780           
  Misses       1130     1130           
  Partials      143      143           
Impacted Files Coverage Δ
src/json-ld.net/Core/Context.cs 89.56% <ø> (ø)
src/json-ld.net/Core/JsonLdError.cs 95.14% <ø> (ø)
src/json-ld.net/Core/JsonLdUtils.cs 27.98% <ø> (ø)
src/json-ld.net/Core/RDFDatasetUtils.cs 54.80% <ø> (ø)
src/json-ld.net/Core/UniqueNamer.cs 100.00% <ø> (ø)
src/json-ld.net/Impl/NQuadRDFParser.cs 25.00% <ø> (ø)
src/json-ld.net/Impl/NQuadTripleCallback.cs 100.00% <ø> (ø)
src/json-ld.net/Impl/TurtleRDFParser.cs 55.42% <ø> (ø)
src/json-ld.net/Impl/TurtleTripleCallback.cs 0.00% <ø> (ø)
src/json-ld.net/Util/JSONUtils.cs 21.62% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be00189...7c89109. Read the comment docs.

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to be released under a new major version, no?

@goofballLogic
Copy link
Member Author

This will have to be released under a new major version, no?

Yeah I'm wondering if we should merge this to a new major version branch instead? Because, we might want to refine the API a bit more if we're doing a major release anyway.

@asbjornu
Copy link
Member

asbjornu commented Oct 1, 2020

I don't think we need another branch for that, we can always just branch out from tag 1.0.6 to support/1.x if we want to do another 1.x release. But then I think we can safely create a 2.0.0 milestone we can add this and possibly other issues to.

@asbjornu asbjornu added this to the 2.0.0 milestone Oct 1, 2020
@goofballLogic goofballLogic merged commit 215ae2a into master Oct 3, 2020
@goofballLogic goofballLogic deleted the issues/76 branch October 3, 2020 16:41
@asbjornu asbjornu mentioned this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce public API to a bare minimum
2 participants