-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues/76 #77
Issues/76 #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 68.59% 68.59%
=======================================
Files 22 22
Lines 4053 4053
Branches 1028 1028
=======================================
Hits 2780 2780
Misses 1130 1130
Partials 143 143
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will have to be released under a new major version, no?
Yeah I'm wondering if we should merge this to a new major version branch instead? Because, we might want to refine the API a bit more if we're doing a major release anyway. |
I don't think we need another branch for that, we can always just branch out from tag |
Closes #76