replace .map with .forEach

linkeddata · Apr 25, 2021 · 1b9789a · 1b9789a
1 parent 9319b20
commit 1b9789a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/src/update-manager.ts b/src/update-manager.ts
@@ -689,7 +689,7 @@ export default class UpdateManager {
     const docs = deletions.concat(insertions).map(st => st.why)
     const thisUpdater = this
     const uniqueDocs: Array<NamedNode> = []
-    docs.map(doc => {
+    docs.forEach(doc => {
         if (!uniqueDocs.find(uniqueDoc => uniqueDoc.equals(doc))) uniqueDocs.push(doc as NamedNode)
      })
     const updates = uniqueDocs.map(doc =>

diff --git a/tests/unit/update-manager-test.js b/tests/unit/update-manager-test.js
@@ -156,23 +156,22 @@ describe('UpdateManager', () => {
     })
 
     // on console should display @@@@@@@     updateMany to: 2
-    it('Should insert triples in more than one document', done => {
+    it('Should insert triples in more than one document', () => {
       loadMeta(updater.store)
       updater.updateMany([], [st1, st2, st3]).then(array => {
-        expect(updater.store.fetcher.webOperation).to.have.been.called() // @@ twice
-      }, err => console.log(err))
-      done()
+        expect(updater.store.fetcher.webOperation).to.have.been.called()
+      })
     })
 
     // on console should display @@@@@@@     updateMany to: 2
-    // and no console error
-    it('Should remove triples in more than one document', async done => {
+    it('Should remove triples in more than one document', done => {
       loadMeta(updater.store)
       updater.updateMany([], [st1, st2, st3])
-      updater.updateMany([st1, st2, st3]).then(array => {
-        expect(updater.store.fetcher.webOperation).to.have.been.called() // @@ twice
-      }, err => { console.log(err) })
-     done()
+      updater.updateMany([st1, st2, st3])
+        .then(array => {
+          expect(updater.store.fetcher.webOperation).to.have.been.called()
+        })
+        .then(() => done(), done)
     })
 /*
     it('Should patch an insert triple with no proior load', done => {