Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create alternate-fetches.md #532

Merged
merged 11 commits into from Nov 29, 2021
Merged

Create alternate-fetches.md #532

merged 11 commits into from Nov 29, 2021

Conversation

jeff-zucker
Copy link
Contributor

Documentation for authenticated and alternate fetch methods. This should resolve #531.

Documentation for authenticated and alternate fetch methods.
Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markup, grammar, etc., for clarity

Documentation/alternate-fetches.md Outdated Show resolved Hide resolved
Documentation/alternate-fetches.md Outdated Show resolved Hide resolved
Documentation/alternate-fetches.md Outdated Show resolved Hide resolved
Documentation/alternate-fetches.md Outdated Show resolved Hide resolved
Documentation/alternate-fetches.md Outdated Show resolved Hide resolved
Documentation/alternate-fetches.md Outdated Show resolved Hide resolved
Documentation/alternate-fetches.md Outdated Show resolved Hide resolved
Documentation/alternate-fetches.md Outdated Show resolved Hide resolved
jeff-zucker and others added 8 commits November 27, 2021 12:26
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@bourgeoa
Copy link
Contributor

bourgeoa commented Nov 28, 2021

I was with the idea that best practice was to avoid using global in javascript.
Why not indicate directly in 3. that you could either use global/window or $rdf.fetcher ?

Co-authored-by: Alain Bourgeois <alain.bourgeois10@gmail.com>
@jeff-zucker
Copy link
Contributor Author

I was with the idea that best practice was to avoid using global in javascript. Why not indicate directly in 3. that you could either use global/window or $rdf.fetcher ?

Yes, that's probably a good idea. I don't know how to make that change without losing the changes you and Ted have made. If I edit the original, it doesn't have any of your changes.

@bourgeoa
Copy link
Contributor

@jeff-zucker

  • On your branch jeff-zucker-alternate-fetches you should git pull locally.
  • or something like git pull origin jeff-zucker-alternate-fetches

Then make the new changes

Copy link
Contributor

@bourgeoa bourgeoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bourgeoa bourgeoa merged commit ec4ac9e into main Nov 29, 2021
@bourgeoa bourgeoa deleted the jeff-zucker-alternate-fetches branch December 26, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How-to add a user-defined fetch()
3 participants